faraphel/chrony
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't use uninitialized values

Browse source 
This fixes a bunch or valgrind errors.
This commit is contained in:
Miroslav Lichvar 2009-10-07 15:11:09 +02:00
parent d06f02be1c
commit 183d56fd40
4 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
client.c
View file

@ -1158,6 +1158,8 @@ submit_request(CMD_Request *request, CMD_Reply *reply, int *reply_auth_ok)
request->utoken = htonl(SPECIAL_UTOKEN); request->utoken = htonl(SPECIAL_UTOKEN);
} }
generate_auth(request); generate_auth(request);
} else {
memset(request->auth, 0, sizeof (request->auth));
} }
command_length = PKL_CommandLength(request); command_length = PKL_CommandLength(request);

2
ntp_core.c
View file

@ -323,6 +323,8 @@ create_instance(NTP_Remote_Address *remote_addr, NTP_Mode mode, SourceParameters
result->local_rx.tv_sec = 0; result->local_rx.tv_sec = 0;
result->local_rx.tv_usec = 0; result->local_rx.tv_usec = 0;
result->local_tx.tv_sec = 0;
result->local_tx.tv_usec = 0;
return result; return result;

5
ntp_io.c
View file

@ -307,13 +307,14 @@ send_packet(void *packet, int packetlen, NTP_Remote_Address *remote_addr)
struct in_pktinfo *ipi; struct in_pktinfo *ipi;
cmsg = CMSG_FIRSTHDR(&msg); cmsg = CMSG_FIRSTHDR(&msg);
memset(cmsg, 0, CMSG_SPACE(sizeof(struct in_pktinfo)));
cmsglen += CMSG_SPACE(sizeof(struct in_pktinfo));
cmsg->cmsg_level = IPPROTO_IP; cmsg->cmsg_level = IPPROTO_IP;
cmsg->cmsg_type = IP_PKTINFO; cmsg->cmsg_type = IP_PKTINFO;
cmsg->cmsg_len = CMSG_LEN(sizeof(struct in_pktinfo)); cmsg->cmsg_len = CMSG_LEN(sizeof(struct in_pktinfo));
cmsglen += CMSG_SPACE(sizeof(struct in_pktinfo));
ipi = (struct in_pktinfo *) CMSG_DATA(cmsg); ipi = (struct in_pktinfo *) CMSG_DATA(cmsg);
memset(ipi, 0, sizeof(struct in_pktinfo));
ipi->ipi_spec_dst.s_addr = htonl(remote_addr->local_ip_addr); ipi->ipi_spec_dst.s_addr = htonl(remote_addr->local_ip_addr);
#if 0 #if 0
LOG(LOGS_INFO, LOGF_NtpIO, "sending to %s:%d from %s", LOG(LOGS_INFO, LOGF_NtpIO, "sending to %s:%d from %s",

3
sourcestats.c
View file

@ -198,6 +198,8 @@ SST_CreateInstance(unsigned long refid)
inst->skew_dirn = SST_Skew_Nochange; inst->skew_dirn = SST_Skew_Nochange;
inst->estimated_offset = 0.0; inst->estimated_offset = 0.0;
inst->estimated_offset_sd = 86400.0; /* Assume it's at least within a day! */ inst->estimated_offset_sd = 86400.0; /* Assume it's at least within a day! */
inst->offset_time.tv_sec = 0;
inst->offset_time.tv_usec = 0;
inst->variance = 16.0; inst->variance = 16.0;
inst->nruns = 0; inst->nruns = 0;
return inst; return inst;
@ -874,6 +876,7 @@ SST_DoSourceReport(SST_Stats inst, RPT_SourceReport *report, struct timeval *now
report->resid_skew = 0; report->resid_skew = 0;
} }
} else { } else {
report->latest_meas_ago = 86400 * 365 * 10;
report->orig_latest_meas = 0; report->orig_latest_meas = 0;
report->latest_meas = 0; report->latest_meas = 0;
report->latest_meas_err = 0; report->latest_meas_err = 0;