faraphel/chrony
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sources: drop unreachable log message

Browse source 
With forced reselection during source removal selected_source_index
can only be INVALID_SOURCE if there are no sources. The "Can't
synchronise: no sources" message couldn't be logged even before that as
SRC_ReselectSource() resets the index before calling SRC_SelectSource().

Replace the message with an assertion.
This commit is contained in:
Miroslav Lichvar 2023-11-21 11:25:10 +01:00
parent 5dd288dc0c
commit 1a15be1e9e
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sources.c
View file

@ -854,11 +854,9 @@ SRC_SelectSource(SRC_Instance updated_inst)
} }
if (n_sources == 0) { if (n_sources == 0) {
/* In this case, we clearly cannot synchronise to anything */ /* Removed sources are unselected before actual removal */
if (selected_source_index != INVALID_SOURCE) { if (selected_source_index != INVALID_SOURCE)
log_selection_message(LOGS_INFO, "Can't synchronise: no sources", NULL); assert(0);
selected_source_index = INVALID_SOURCE;
}
return; return;
} }