faraphel/chrony
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sources: optimize SRC_ReportSource() a bit

Browse source 
Remove unnecessary memset() call and use the default case of the switch
to report the unreachable state.
This commit is contained in:
Miroslav Lichvar 2016-07-19 15:57:16 +02:00
parent 5e92aaf8a5
commit 316d50d6f1
1 changed files with 1 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
sources.c
View file

@ -1294,7 +1294,6 @@ SRC_ReportSource(int index, RPT_SourceReport *report, struct timeval *now)
} else { } else {
src = sources[index]; src = sources[index];
memset(&report->ip_addr, 0, sizeof (report->ip_addr));
if (src->ip_addr) if (src->ip_addr)
report->ip_addr = *src->ip_addr; report->ip_addr = *src->ip_addr;
else { else {
@ -1304,14 +1303,6 @@ SRC_ReportSource(int index, RPT_SourceReport *report, struct timeval *now)
} }
switch (src->status) { switch (src->status) {
case SRC_UNSELECTABLE:
case SRC_BAD_STATS:
case SRC_BAD_DISTANCE:
case SRC_STALE:
case SRC_ORPHAN:
case SRC_WAITS_STATS:
report->state = RPT_UNREACH;
break;
case SRC_FALSETICKER: case SRC_FALSETICKER:
report->state = RPT_FALSETICKER; report->state = RPT_FALSETICKER;
break; break;
@ -1331,9 +1322,8 @@ SRC_ReportSource(int index, RPT_SourceReport *report, struct timeval *now)
case SRC_SELECTED: case SRC_SELECTED:
report->state = RPT_SYNC; report->state = RPT_SYNC;
break; break;
case SRC_OK:
default: default:
assert(0); report->state = RPT_UNREACH;
break; break;
} }