faraphel/chrony
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove socket binding in chronyc

Browse source 
Randomly assigned port should work fine, no need for binding.
This commit is contained in:
Miroslav Lichvar 2009-12-07 12:31:35 +01:00
parent ff423304ed
commit 395c33208c
1 changed files with 0 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
client.c
View file

@ -146,7 +146,6 @@ read_line(void)
static void static void
open_io(const char *hostname, int port) open_io(const char *hostname, int port)
{ {
union sockaddr_in46 my_addr;
IPAddr ip; IPAddr ip;
/* Note, this call could block for a while */ /* Note, this call could block for a while */
@ -155,17 +154,12 @@ open_io(const char *hostname, int port)
exit(1); exit(1);
} }
memset(&my_addr, 0, sizeof (my_addr));
memset(&his_addr, 0, sizeof (his_addr)); memset(&his_addr, 0, sizeof (his_addr));
switch (ip.family) { switch (ip.family) {
case IPADDR_INET4: case IPADDR_INET4:
sock_fd = socket(AF_INET, SOCK_DGRAM, 0); sock_fd = socket(AF_INET, SOCK_DGRAM, 0);
my_addr.in4.sin_family = AF_INET;
my_addr.in4.sin_port = htons(INADDR_ANY);
my_addr.in4.sin_addr.s_addr = htonl(INADDR_ANY);
his_addr.in4.sin_family = AF_INET; his_addr.in4.sin_family = AF_INET;
his_addr.in4.sin_addr.s_addr = htonl(ip.addr.in4); his_addr.in4.sin_addr.s_addr = htonl(ip.addr.in4);
his_addr.in4.sin_port = htons(port); his_addr.in4.sin_port = htons(port);
@ -174,10 +168,6 @@ open_io(const char *hostname, int port)
case IPADDR_INET6: case IPADDR_INET6:
sock_fd = socket(AF_INET6, SOCK_DGRAM, 0); sock_fd = socket(AF_INET6, SOCK_DGRAM, 0);
my_addr.in6.sin6_family = AF_INET6;
my_addr.in6.sin6_port = htons(INADDR_ANY);
my_addr.in6.sin6_addr = in6addr_any;
his_addr.in6.sin6_family = AF_INET6; his_addr.in6.sin6_family = AF_INET6;
memcpy(his_addr.in6.sin6_addr.s6_addr, ip.addr.in6, memcpy(his_addr.in6.sin6_addr.s6_addr, ip.addr.in6,
sizeof (his_addr.in6.sin6_addr.s6_addr)); sizeof (his_addr.in6.sin6_addr.s6_addr));
@ -193,11 +183,6 @@ open_io(const char *hostname, int port)
exit(1); exit(1);
} }
if(bind(sock_fd, &my_addr.u, sizeof(my_addr)) < 0) {
perror("Can't bind socket");
exit(1);
}
return; return;
} }