From 4b511143b876ebbf02a67bf63d879c2513b30aee Mon Sep 17 00:00:00 2001 From: Bryan Christianson Date: Wed, 9 Aug 2017 05:14:05 +1200 Subject: [PATCH] sys_netbsd: fix adjtime() fault on macOS On some systems, passing NULL as the first argument to adjtime, will result in returning the amount of adjustment outstanding from a previous call to adjtime(). On macOS this is not allowed and the adjtime call will fault. We can simulate the behaviour of the other systems by cancelling the current adjustment then restarting the adjustment using the outstanding time that was returned. On macOS 10.13 and later, the netbsd driver is now used and must use these semantics when making/measuring corrections. --- sys_netbsd.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sys_netbsd.c b/sys_netbsd.c index ba66b12..840d6a5 100644 --- a/sys_netbsd.c +++ b/sys_netbsd.c @@ -84,9 +84,18 @@ get_offset_correction(struct timespec *raw, { struct timeval remadj; double adjustment_remaining; +#ifdef MACOSX + struct timeval tv = {0, 0}; + if (PRV_AdjustTime(&tv, &remadj) < 0) + LOG_FATAL("adjtime() failed"); + + if (PRV_AdjustTime(&remadj, NULL) < 0) + LOG_FATAL("adjtime() failed"); +#else if (PRV_AdjustTime(NULL, &remadj) < 0) LOG_FATAL("adjtime() failed"); +#endif adjustment_remaining = UTI_TimevalToDouble(&remadj);