From 53353529cf585ce6605e868d3a94faf3397cafae Mon Sep 17 00:00:00 2001 From: Miroslav Lichvar Date: Mon, 29 Nov 2021 12:30:09 +0100 Subject: [PATCH] rtc: don't drop first sample after initial trim It seems there is no longer an issue with the first sample after the initial trim and it can be accumulated. It might have been a workaround for an unrelated bug which was fixed since then. This fixes the number of samples reported in rtcdata briefly jumping to 65535 and also brings back the expectation that n_samples is never negative. --- rtc_linux.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/rtc_linux.c b/rtc_linux.c index c61f720..58b625b 100644 --- a/rtc_linux.c +++ b/rtc_linux.c @@ -189,14 +189,10 @@ accumulate_sample(time_t rtc, struct timespec *sys) } /* Always use most recent sample as reference */ - /* use sample only if n_sample is not negative*/ - if(n_samples >=0) - { rtc_ref = rtc; rtc_sec[n_samples] = rtc; system_times[n_samples] = *sys; ++n_samples_since_regression; - } ++n_samples; } @@ -633,11 +629,7 @@ handle_initial_trim(void) run_regression(1, &coefs_valid, &coef_ref_time, &coef_seconds_fast, &coef_gain_rate); n_samples_since_regression = 0; - - /* Set sample number to -1 so the next sample is not used, as it will not yet be corrected for System Trim*/ - - n_samples = -1; - + n_samples = 0; read_coefs_from_file();