faraphel/chrony
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

nameserv: check that address returned from gethostbyname() is IPv4

Browse source 
Also, always return failure with -6.
This commit is contained in:
Miroslav Lichvar 2014-10-21 13:50:52 +02:00
parent ccaf0874e1
commit 699680807d
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
nameserv.c
View file

@ -88,12 +88,18 @@ DNS_Name2IPAddress(const char *name, IPAddr *addr)
#else #else
struct hostent *host; struct hostent *host;
if (address_family != IPADDR_UNSPEC && address_family != IPADDR_INET4)
return DNS_Failure;
host = gethostbyname(name); host = gethostbyname(name);
if (host == NULL) { if (host == NULL) {
if (h_errno == TRY_AGAIN) if (h_errno == TRY_AGAIN)
return DNS_TryAgain; return DNS_TryAgain;
} else { } else {
if (host->h_addrtype != AF_INET || !host->h_addr_list[0])
return DNS_Failure;
addr->family = IPADDR_INET4; addr->family = IPADDR_INET4;
addr->addr.in4 = ntohl(*(uint32_t *)host->h_addr_list[0]); addr->addr.in4 = ntohl(*(uint32_t *)host->h_addr_list[0]);
return DNS_Success; return DNS_Success;