faraphel/chrony
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sched: free timer blocks on exit

Browse source 
Save pointers to allocated timer blocks and free them on exit. This
fixes the long-standing annoying "possibly lost" leak reported by
valgrind.
This commit is contained in:
Miroslav Lichvar 2023-04-12 16:48:36 +02:00
parent 4f674539fd
commit 6ea1082a72
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
sched.c
View file

@ -104,7 +104,10 @@ static unsigned long n_timer_queue_entries;
static SCH_TimeoutID next_tqe_id; static SCH_TimeoutID next_tqe_id;
/* Pointer to head of free list */ /* Pointer to head of free list */
static TimerQueueEntry *tqe_free_list = NULL; static TimerQueueEntry *tqe_free_list;
/* Array of all allocated tqe blocks to be freed in finalisation */
static ARR_Instance tqe_blocks;
/* Timestamp when was last timeout dispatched for each class */ /* Timestamp when was last timeout dispatched for each class */
static struct timespec last_class_dispatch[SCH_NumberOfClasses]; static struct timespec last_class_dispatch[SCH_NumberOfClasses];
@ -133,6 +136,8 @@ SCH_Initialise(void)
n_timer_queue_entries = 0; n_timer_queue_entries = 0;
next_tqe_id = 0; next_tqe_id = 0;
tqe_free_list = NULL;
tqe_blocks = ARR_CreateInstance(sizeof (TimerQueueEntry *));
timer_queue.next = &timer_queue; timer_queue.next = &timer_queue;
timer_queue.prev = &timer_queue; timer_queue.prev = &timer_queue;
@ -154,8 +159,14 @@ SCH_Initialise(void)
void void
SCH_Finalise(void) { SCH_Finalise(void) {
unsigned int i;
ARR_DestroyInstance(file_handlers); ARR_DestroyInstance(file_handlers);
for (i = 0; i < ARR_GetSize(tqe_blocks); i++)
Free(*(TimerQueueEntry **)ARR_GetElement(tqe_blocks, i));
ARR_DestroyInstance(tqe_blocks);
LCL_RemoveParameterChangeHandler(handle_slew, NULL); LCL_RemoveParameterChangeHandler(handle_slew, NULL);
initialised = 0; initialised = 0;
@ -281,6 +292,7 @@ allocate_tqe(void)
} }
new_block[0].next = NULL; new_block[0].next = NULL;
tqe_free_list = &(new_block[TQE_ALLOC_QUANTUM - 1]); tqe_free_list = &(new_block[TQE_ALLOC_QUANTUM - 1]);
ARR_AppendElement(tqe_blocks, &new_block);
} }
result = tqe_free_list; result = tqe_free_list;