From 88f846f6563349c124106baeb51f9d928290aa64 Mon Sep 17 00:00:00 2001 From: Miroslav Lichvar Date: Tue, 22 Oct 2019 14:50:00 +0200 Subject: [PATCH] rtc: don't clone file attributes of rtc file When replacing an existing rtc file with the temporary file, don't change the ownership or permissions of the temporary file to match the old rtc file, as if it didn't exist. --- rtc_linux.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/rtc_linux.c b/rtc_linux.c index d4d9bd0..ae9a3fa 100644 --- a/rtc_linux.c +++ b/rtc_linux.c @@ -466,7 +466,6 @@ read_coefs_from_file(void) static int write_coefs_to_file(int valid,time_t ref_time,double offset,double rate) { - struct stat buf; char *temp_coefs_file_name; FILE *out; int r1, r2; @@ -501,17 +500,6 @@ write_coefs_to_file(int valid,time_t ref_time,double offset,double rate) return RTC_ST_BADFILE; } - /* Clone the file attributes from the existing file if there is one. */ - - if (!stat(coefs_file_name,&buf)) { - if (chown(temp_coefs_file_name,buf.st_uid,buf.st_gid) || - chmod(temp_coefs_file_name,buf.st_mode & 0777)) { - LOG(LOGS_WARN, - "Could not change ownership or permissions of temporary RTC file %s.tmp", - coefs_file_name); - } - } - /* Rename the temporary file to the correct location (see rename(2) for details). */ if (rename(temp_coefs_file_name,coefs_file_name)) {