Fix Clang static analyzer warnings about never read values

This commit is contained in:
Miroslav Lichvar 2013-10-07 16:10:25 +02:00
parent d5a9c1535e
commit 922e2fe23b
3 changed files with 5 additions and 4 deletions

View file

@ -1937,8 +1937,6 @@ read_from_cmd_socket(void *anything)
/* This should be already handled */ /* This should be already handled */
assert(0); assert(0);
} else { } else {
allowed = 0;
/* Check level of authority required to issue the command */ /* Check level of authority required to issue the command */
switch(permissions[rx_command]) { switch(permissions[rx_command]) {
case PERMIT_AUTH: case PERMIT_AUTH:
@ -1960,6 +1958,7 @@ read_from_cmd_socket(void *anything)
break; break;
default: default:
assert(0); assert(0);
allowed = 0;
} }
if (allowed) { if (allowed) {

View file

@ -1548,6 +1548,8 @@ NCR_SlewTimes(NCR_Instance inst, struct timeval *when, double dfreq, double doff
#ifdef TRACEON #ifdef TRACEON
LOG(LOGS_INFO, LOGF_NtpCore, "rx prev=[%s] new=[%s]", LOG(LOGS_INFO, LOGF_NtpCore, "rx prev=[%s] new=[%s]",
UTI_TimevalToString(&prev), UTI_TimevalToString(&inst->local_rx)); UTI_TimevalToString(&prev), UTI_TimevalToString(&inst->local_rx));
#else
(void)prev;
#endif #endif
prev = inst->local_tx; prev = inst->local_tx;
if (inst->local_tx.tv_sec || inst->local_tx.tv_usec) if (inst->local_tx.tv_sec || inst->local_tx.tv_usec)

View file

@ -631,7 +631,7 @@ SST_SlewSamples(SST_Stats inst, struct timeval *when, double dfreq, double doffs
i, UTI_TimevalToString(&prev), UTI_TimevalToString(sample), i, UTI_TimevalToString(&prev), UTI_TimevalToString(sample),
prev_offset, inst->offsets[i]); prev_offset, inst->offsets[i]);
#else #else
(void)prev_offset; (void)prev; (void)prev_offset;
#endif #endif
} }
@ -650,7 +650,7 @@ SST_SlewSamples(SST_Stats inst, struct timeval *when, double dfreq, double doffs
prev_offset, inst->estimated_offset, prev_offset, inst->estimated_offset,
1.0e6*prev_freq, 1.0e6*inst->estimated_frequency); 1.0e6*prev_freq, 1.0e6*inst->estimated_frequency);
#else #else
(void)prev; (void)prev_freq; (void)prev; (void)prev_offset; (void)prev_freq;
#endif #endif
} }