From 96771d68574dfc8da125480838f96c38efd2f0cc Mon Sep 17 00:00:00 2001 From: Miroslav Lichvar Date: Tue, 22 Oct 2019 15:25:03 +0200 Subject: [PATCH] logging: make banner printing safer Don't rely on the buffer filled with '=' characters to be always at least as long as the log-specific banner string. --- logging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/logging.c b/logging.c index e12bad7..1993ab7 100644 --- a/logging.c +++ b/logging.c @@ -289,7 +289,7 @@ LOG_FileWrite(LOG_FileID id, const char *format, ...) char bannerline[256]; int i, bannerlen; - bannerlen = strlen(logfiles[id].banner); + bannerlen = MIN(strlen(logfiles[id].banner), sizeof (bannerline) - 1); for (i = 0; i < bannerlen; i++) bannerline[i] = '=';