faraphel/chrony
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ntp: log failed connection to Samba signd socket

Browse source 
Log an error message (in addition to the socket-specific debug message)
when the connection to signd socket fails, but only once before a
successful signd exchange to avoid flooding the system log.
This commit is contained in:
Miroslav Lichvar 2024-04-15 16:19:06 +02:00
parent dcc94a4c10
commit bb5db828c6
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
ntp_signd.c
View file

@ -99,6 +99,9 @@ static int sock_fd;
/* Flag indicating if the MS-SNTP authentication is enabled */ /* Flag indicating if the MS-SNTP authentication is enabled */
static int enabled; static int enabled;
/* Flag limiting logging of connection error messages */
static int logged_connection_error;
/* ================================================== */ /* ================================================== */
static void read_write_socket(int sock_fd, int event, void *anything); static void read_write_socket(int sock_fd, int event, void *anything);
@ -134,6 +137,14 @@ open_socket(void)
sock_fd = SCK_OpenUnixStreamSocket(path, NULL, 0); sock_fd = SCK_OpenUnixStreamSocket(path, NULL, 0);
if (sock_fd < 0) { if (sock_fd < 0) {
sock_fd = INVALID_SOCK_FD; sock_fd = INVALID_SOCK_FD;
/* Log an error only once before a successful exchange to avoid
flooding the system log */
if (!logged_connection_error) {
LOG(LOGS_ERR, "Could not connect to signd socket %s : %s", path, strerror(errno));
logged_connection_error = 1;
}
return 0; return 0;
} }
@ -160,6 +171,8 @@ process_response(SignInstance *inst)
return; return;
} }
logged_connection_error = 0;
/* Check if the file descriptor is still valid */ /* Check if the file descriptor is still valid */
if (!NIO_IsServerSocket(inst->local_addr.sock_fd)) { if (!NIO_IsServerSocket(inst->local_addr.sock_fd)) {
DEBUG_LOG("Invalid NTP socket"); DEBUG_LOG("Invalid NTP socket");