faraphel/chrony
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ntp: fix authenticated requests in serverstats

Browse source 
Fix the CLG_UpdateNtpStats() call to count requests passing the
authentication check instead of requests triggering a KoD response
(i.e. NTS NAK).
This commit is contained in:
Miroslav Lichvar 2024-01-08 11:35:56 +01:00
parent 120dfb8b36
commit e11b518a1f
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ntp_core.c
View file

@ -2736,7 +2736,7 @@ NCR_ProcessRxUnknown(NTP_Remote_Address *remote_addr, NTP_Local_Address *local_a
CLG_DisableNtpTimestamps(&ntp_rx); CLG_DisableNtpTimestamps(&ntp_rx);
} }
CLG_UpdateNtpStats(kod != 0 && info.auth.mode != NTP_AUTH_NONE && CLG_UpdateNtpStats(kod == 0 && info.auth.mode != NTP_AUTH_NONE &&
info.auth.mode != NTP_AUTH_MSSNTP, info.auth.mode != NTP_AUTH_MSSNTP,
rx_ts->source, interleaved ? tx_ts->source : NTP_TS_DAEMON); rx_ts->source, interleaved ? tx_ts->source : NTP_TS_DAEMON);

5
test/system/010-nts
View file

@ -45,6 +45,11 @@ check_chronyc_output "^Name/IP address Mode KeyID Type KLen Last Atm
========================================================================= =========================================================================
127\.0\.0\.1 NTS 1 (30|15) (128|256) [0-9] 0 0 [78] ( 64|100)$" || test_fail 127\.0\.0\.1 NTS 1 (30|15) (128|256) [0-9] 0 0 [78] ( 64|100)$" || test_fail
run_chronyc "serverstats" || test_fail
check_chronyc_output "NTS-KE connections accepted: 1
NTS-KE connections dropped : 0
Authenticated NTP packets : [1-9][0-9]*" || test_fail
stop_chronyd || test_fail stop_chronyd || test_fail
check_chronyd_messages || test_fail check_chronyd_messages || test_fail
check_chronyd_files || test_fail check_chronyd_files || test_fail